Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to ignore empty model ID #995

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Fix to ignore empty model ID #995

merged 1 commit into from
Oct 20, 2023

Conversation

ganeshrn
Copy link
Member

  • If model ID is set to empty set it to undefined and don't send it to the lightspeed endpoint
  • Trim the model ID value of the whitespaces

Fix to ignore empty model ID
c398707 
*  If model ID is set to empty set it to `undefined`
   and don't send it to the lightspeed endpoint
*  Trim the model ID value of the whitespaces
@ganeshrn ganeshrn requested a review from a team as a code owner October 20, 2023 14:43
@ganeshrn ganeshrn temporarily deployed to ack October 20, 2023 14:43 — with GitHub Actions Inactive
@ganeshrn ganeshrn added the bug Something isn't working label Oct 20, 2023
@ganeshrn ganeshrn temporarily deployed to ack October 20, 2023 15:06 — with GitHub Actions Inactive
@ganeshrn ganeshrn merged commit 2e66713 into ansible:main Oct 20, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianonicolai cristianonicolai Awaiting requested review from cristianonicolai cristianonicolai is a code owner automatically assigned from ansible/devtools

@audgirka audgirka Awaiting requested review from audgirka audgirka is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug Something isn't working
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ganeshrn